Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect (but working) writer/reader generation for complex sum types #325

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fixed incorrect (but working) writer/reader generation for complex sum types #325

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c971cc
fixed incorrect (but working) writer/reader generation for complex su…
Oct 23, 2024
aa560cb
fixed incorrect (but working) writer/reader generation for complex su…
Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions modules/core/src/main/scala-3/tethys/derivation/ConfigurationMacroUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,17 +752,19 @@ trait ConfigurationMacroUtils:
case '[t *: ts] => TypeRepr.of[t] :: typeReprsOf[ts]

def getAllChildren(tpe: TypeRepr): List[TypeRepr] =
tpe.asType match
case '[t] =>
Expr.summon[scala.deriving.Mirror.Of[t]] match
case Some('{
$m: scala.deriving.Mirror.SumOf[t] {
type MirroredElemTypes = subs
}
}) =>
typeReprsOf[subs].flatMap(getAllChildren)
case _ =>
List(tpe)
def loop(tpe: TypeRepr): List[TypeRepr] =
tpe.asType match
case '[t] =>
Expr.summon[scala.deriving.Mirror.Of[t]] match
case Some('{
$m: scala.deriving.Mirror.SumOf[t] {
type MirroredElemTypes = subs
}
}) =>
typeReprsOf[subs].flatMap(loop)
case _ =>
List(tpe)
loop(tpe).distinct

case class SelectedField(name: String, selector: Term)

Expand Down