made links shorter by adding aliases #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Burhan-Q
approved these changes
Jul 19, 2024
|
Hi @Burhan-Q thanks for the review. I made the changes suggested. |
Burhan-Q
reviewed
Jul 19, 2024
new
Outdated
There was a problem hiding this comment.
I don't think you want to add this to the repo. Also, now that it's here, you probably need to remove this key
Burhan-Q
reviewed
Jul 19, 2024
new .pub
Outdated
There was a problem hiding this comment.
This should also not be included
Burhan-Q
requested changes
Jul 19, 2024
|
Sorry, removed the files now. |
Burhan-Q
approved these changes
Jul 19, 2024
capsulecorplab
requested changes
Jul 23, 2024
There was a problem hiding this comment.
Should remove .vscode/settings.json since we're not using Antora. Otherwise, LGTM
|
@capsulecorplab Removed the settings.json file. |
|
Thanks @Venkat4real ! Though it looks like you closed the PR without merging. Would you mind re-opening? |
|
Hi Sean @capsulecorplab . I reopened the PR |
capsulecorplab
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the issue #131