[Includes] Some improvements #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make include file system (and provider) interfaces to have an include type paramter as well as file Name Make all current file systems to accept include type (but do no modify their behaviour) Add IsLocal in DirectiveTriviaSyntax (to indicate if we want a local or system include) Lexer on open file check for is local to set include type properly prior to call OpenInclude
Allow syntax compiler to pass it's own file resolver. (Since file system can be in memory, in that case resolver would never find the file, so file system would never get called)
Make source file constructor public (otherwise it's no possible to ever provide a custom file resolver outside of the assembly itself) Add test for include directive (checks that tokens are found and that they have correct settings) Add test to use a custom file resolver (verifies that it will be called)
I agree - let's remove |
|
This did not, issue is there been a large change in between and this will conflict merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, as mentioned in #130 , here are some improvements for include system :
The main rationale about it is to also allow some finer control when using core libraries in custom tooling.
Added Include type enumeration
IncludeDirectiveTriviaSyntax gets a boolean "IsLocal"
Pass Include type to both Include Resolver and File System (depending on local flag)
Current file systems and resolver are ignoring flag (so this will not be a breaking change)
Allow to pass our own IIncludeFileResolver to ParseSyntaxTree .
To be allowed to use our own IIncludeFileResolver, we need to provide a source file, so constructor is now public.
I added small tests to verify that syntax flags are correct, and that custom resolver gets called properly.
One discussion part I would have, is that passing IIncludeFileResolver is required, since our include system might not be not file based (zip/resource/memory...) so default resolver will never find the file, and never call the filesystem.
So maybe we should even remove IIncludeFileSystem from the argument list (since resolver should provide it's own file system anyway, or never provide one) ?
Thanks