Line directive has optional filename argument. #266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParseLineDirective
I create the missing tokenEndOfDirectiveToken
. I'm not sure if its ok, but it works.HlslLexer.LexDirectiveToken
must reset his value_value = null;
before parsing, likeHlslLexer.LexSyntaxToken
. Because some directives have no value and it extrapolates the previous one to next - bad.afterLineNumber
argument fromParseEndOfDirective
. It looks like a special error for the line directive, it referred toMissingPreprocessorFile
but was never used.#line
without filename, it also checking if the end of directive is parsed correctly.LineDirectiveTrivia
kind. No more special cases for 0, -1, -2 line number. It just should be >= 0. Yes, correlates with the latest DXC release!