-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Mac builds #10
Open
aaronreidsmith
wants to merge
27
commits into
master
Choose a base branch
from
mac-builds
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[MRG] Mac builds #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f4f49c9.
@tgsmith61591 This was in my backlog of open PRs. I got it working, if we want to merge this (we don't have an appveyor config, so it is failing). Windows is still being annoying, but Mac and Linux work. We just need to add deploy vars (twine username and password) to the azure pipeline |
aaronreidsmith
force-pushed
the
mac-builds
branch
from
July 20, 2020 20:47
7053619
to
8917c1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds builds for mac. Currently, it does not deploy to PyPI. We still need the
deploy-vars
group on ADO. Since we decided to just do mac + Linux for now, this branched off ofadd-azure
... We can use that branch to play around with Windows, or create a new one