Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(synced-lyrics): fix lyrics loading with adblocker; properly fix album name #2318

Closed
wants to merge 1 commit into from

Conversation

Reycko
Copy link
Contributor

@Reycko Reycko commented Aug 2, 2024

Using JSON.parse(await response.text()); seems to work better than await response.json();, for some reason. This fixes compatibility with certain plugins (e.g. adblocker) and lets lyrics load properly.

image

@Reycko Reycko changed the title fix(synced-lyrics): fix lyrics loading with adblocker fix(synced-lyrics): fix lyrics loading with adblocker; properly fix album name Aug 2, 2024
@JellyBrick JellyBrick added the bug Something isn't working label Aug 2, 2024
@JellyBrick
Copy link
Collaborator

fixed at 7656c41

@JellyBrick JellyBrick closed this Aug 4, 2024
@derfurkan
Copy link

fixed at 7656c41

Not sure if this is actually fixed since i still experience it. Using the latest version.

@JellyBrick
Copy link
Collaborator

@derfurkan It's not released yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants