Forgot password page #211
Merged
Forgot password page #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iibarbari
force-pushed
the
forgot-password-page
branch
from
91db9b4
to
92b9c80
Compare
iibarbari
added
status: ready for review
status: in progress
and removed
status: in progress
status: ready for review
labels
th0th
force-pushed
the
forgot-password-page
branch
from
0f0e082
to
3644430
Compare
th0th
requested changes
Nov 18, 2024
There was a problem hiding this comment.
- We have multiple and identical
FormTitlecomponents around, not sure if it is intentional. - Let's stick with noun component names. Can you please rename
ForgotPasswordasPasswordRecovery? 💐 - "Forgot password?" link on the sign in page fully reloads the page when clicked.
- It would be cool if the e-mail input is populated when I already fill in my e-mail address on the sign in form, and then click the "Forgot password?" link. I am not sure if
wouterhas a way of passing state between routes, or if we would have to use query parameters for this.
Please go ahead and merge without further approval once these are addressed 💐
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.