Enabling more formats to input hours and minutes in preferences

[TaranDev]

Related issue

Closes #914

Context / Background

• Previously the input of the "Hours per day" and "Break time interval" preferences sections were restricted to an XX:XX format, this PR introduces more formats that can be used.

What change is being introduced by this PR?

• You can now use X, XX, XX.X, X.XX, X:XX, and XX.XX in addition to the default XX:XX format when entering hours and minutes into the "Hours per day" and "Break time interval" sections in preferences.
• If the entered value matches one of these formats, it will be converted to match XX:XX before being saved as a preference.
• This involved changing the pattern regex for those fields in preferences.html, and performing some case checks and string manipulation in preferences.js.

Before change:

After change:

[tupaschoal]

Can you rebase to make sure it is not breaking any of the tests introduced earlier this morning?

Also please revert the changes to changelog.md

[TaranDev]

Hi,

I've reverted changelog.md

When I rebase, I'm intermittently passing and failing 2 of the tests for workday-waiver:

However the same happens on a fresh clone of the repo and the failing tests don't seem related to my changes, so I don't believe my code changes are the cause of the issue.

[araujoarthur0]

We can ignore these two tests, I'm fixing them in a different PR.

[codecov]

Codecov Report

Merging #1020 (2b529d6) into main (8026942) will increase coverage by 2.10%.
Report is 20 commits behind head on main.
The diff coverage is 35.00%.

❗ Current head 2b529d6 differs from pull request most recent head 3c0ed37. Consider uploading reports for the commit 3c0ed37 to get more accurate results

@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
+ Coverage   72.56%   74.67%   +2.10%     
==========================================
  Files          26       26              
  Lines        2180     2207      +27     
  Branches      345      352       +7     
==========================================
+ Hits         1582     1648      +66     
+ Misses        598      559      -39     

Files	Coverage Δ
src/preferences.js	75.00% <35.00%> (-9.27%)	⬇️

... and 7 files with indirect coverage changes

[araujoarthur0]

Thanks for submitting this. Please take a look at my suggestions.

[araujoarthur0]

When one inputs something wrong, the html message asks to follow the requested format, but that is not explicit.
Is there a way to customize that html message?

[araujoarthur0]

Also, consider if it's possible to implement extra tests for this behavior to ensure it's always working.

[TaranDev]

Thanks for the suggestions araujoarthur0, I'll probably start working on them when I'm free this weekend

[araujoarthur0]

Thanks for implementing the revisions @TaranDev!
Do you think it would be possible to add tests?
There's also a conflict with the package-lock.json. It's better to avoid committing changes to that file.

[thamara]

Here are some tests I suggest:

describe('convertTimeFormat', () => {
    it('should convert single digit hour to HH:MM format', () => {
        expect(convertTimeFormat('6')).toBe('06:00');
    });

    it('should convert double digit hour to HH:MM format', () => {
        expect(convertTimeFormat('12')).toBe('12:00');
    });

    it('should convert H.MM format to HH:MM format', () => {
        expect(convertTimeFormat('6.5')).toBe('06:30');
    });

    it('should convert H.MM format to HH:MM format', () => {
        expect(convertTimeFormat('6.50')).toBe('06:30');
    });

    it('should convert HH.MM format to HH:MM format', () => {
        expect(convertTimeFormat('12.5')).toBe('12:30');
    });

    it('should convert H:MM format to HH:MM format', () => {
        expect(convertTimeFormat('6:30')).toBe('06:30');
    });

    it('should convert HH:MM format to HH:MM format', () => {
        expect(convertTimeFormat('12:30')).toBe('12:30');
    });
});