Deprecate old db #1053
Deprecate old db #1053
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1053 +/- ##
==========================================
+ Coverage 79.36% 81.29% +1.93%
==========================================
Files 19 20 +1
Lines 1231 1203 -28
Branches 183 176 -7
==========================================
+ Hits 977 978 +1
+ Misses 254 225 -29 ☔ View full report in Codecov by Sentry. |
| @@ -144,26 +130,12 @@ function importDatabaseFromFile(filename) | |||
| } | |||
| else | |||
| { | |||
| assert(entry.type === 'flexible'); | |||
There was a problem hiding this comment.
Can we write something on the test that hit this assert?
| @@ -6,6 +6,7 @@ import fs from 'fs'; | |||
|
|
|||
| import { validateTime } from './time-math.js'; | |||
| import { generateKey } from './date-db-formatter.js'; | |||
| import { assert } from 'console'; | |||
There was a problem hiding this comment.
I'm trying to keep all external imports at the top of the file, and local imports below
| @@ -6,6 +6,7 @@ import fs from 'fs'; | |||
|
|
|||
| import { validateTime } from './time-math.js'; | |||
| import { generateKey } from './date-db-formatter.js'; | |||
| import { assert } from 'console'; | |||
|
|
|||
| /** | |||
| * Returns the database (only flexible calendar entries) as an array of: | |||
There was a problem hiding this comment.
maybe we can also remove the "flexible" comments and name functions now that the other doesn't exist anymore
| flexibleEntry.values.splice(index, 0, oldStoreHours); | ||
| return flexibleEntry; | ||
| } | ||
|
|
||
| function importDatabaseFromFile(filename) | ||
| { | ||
| const flexibleStore = new Store({name: 'flexible-store'}); |
There was a problem hiding this comment.
Likewise this doesn't need to be called flexibleStore anymore
Maybe just store or entryStore
| @@ -27,7 +27,7 @@ describe('Validate json', function() | |||
| }); | |||
| }); | |||
|
|
|||
| describe('validate date with and without leading 0', function() | |||
| describe('validate date with and without leading 0', function() | |||
There was a problem hiding this comment.
should this be in a separate pr/commit?
Related issue
Closes #935.
Context / Background
The old database format (fixed in 4 entries) is in deprecation since may of 2021, as we move with other features, it's time to remove any mention/handling of such database.
What change is being introduced by this PR?
Removed related code and unnecessary strings.
How will this be tested?
Hopefully with the CI. :)