Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Traditional Chinese Translation (#496) #498

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Add: Traditional Chinese Translation (#496) #498

merged 1 commit into from
Oct 22, 2020

Conversation

jswildcards
Copy link
Contributor

@jswildcards jswildcards commented Oct 22, 2020

Add: Traditional Chinese Translation (#496)

Related issue

Closes #496

Context / Background

Added Traditional Chinese Translation

What change is being introduced by this PR?

The translation is added following the guide on #475:

  • Add the language locale in src/configs/app.config.js, on the array languages

  • Create a new directory under locales, with the locale of the language

  • Copy the json files from locales/en/ to the new created directory

  • Translate the strings in the new locales/{LANG}/translation.json

  • You'll see strings for "Time to Leave". This is the app name, and you don't need to translate it.

  • Remember to include the new added language in all translation.json files, under the "$Language" scope. The name for the language across all file should not be translations, but instead be the native name for the language

  • Translate README, by creating a new docs/README-{LANG}.md, with a copy of the main README.md, but translating into the specific languagem

  • Include a reference to newly created docs/README-{LANG}.md in README.md, close to the top, stating: "This document is also available in {LANG}", but translated to the targeted language

How will this be tested?

Add: Traditional Chinese Translation (#496)
Copy link
Owner

thamara commented Oct 22, 2020

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 1
           

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #498 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   66.88%   66.88%           
=======================================
  Files          28       28           
  Lines        2564     2564           
  Branches      388      388           
=======================================
  Hits         1715     1715           
  Misses        755      755           
  Partials       94       94           
Impacted Files Coverage Δ
src/configs/app.config.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1834635...bf2b591. Read the comment docs.

Copy link
Owner

@thamara thamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really good, even though I didn't understand anything hahahaha

@thamara thamara merged commit 3645ec7 into thamara:main Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate Time to Leave to zh-TW
2 participants