Added Hindi Language to Time-To-leave #499
Conversation
Codecov Report
@@ Coverage Diff @@
## main #499 +/- ##
=======================================
Coverage 66.88% 66.88%
=======================================
Files 28 28
Lines 2564 2564
Branches 388 388
=======================================
Hits 1715 1715
Misses 755 755
Partials 94 94
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I found it a bit interesting that on translation.json you changed the order of the scopes, was there any specific reason for this?
My suspicion is that you have sorted alphabetically this, but this makes a bit harder when reviewing and making it consistent between all files. I don't mind the sorting in the same scope (for example, under the same $something context), as we'll be standardizing this in other languages, but for the major scopes, I would prefer to keep it in the same existing order.
Can you please adjust this?
Other than that, the changes look good, a few minor comments, but overall great. (Even though I don't know Hindi to have any opinion on the translation).
There was a problem hiding this comment.
Oh, another thing that is missing here is to add the language "hi": "नहीं।", under the $Language scope of the translation file for the other languages, currently these should be:
locales/en/translation.jsonlocales/es/translation.jsonlocales/it/translation.jsonlocales/pt-BR/translation.json
|
Ok will do all the suggested changes |
|
Note that there are some merge conflicts, please rebase and solve those. Let us know if you need help! |
Removed Trailing spaces
Co-authored-by: Thamara Andrade <tkcandrade@gmail.com>
Translated the word city.
Fixed proper translation for tue : "मंगल"
|
Thanks! I'll continue the merge :D |
|
\changelog-update |
Related issue
Closes #475 #497
Context / Background
w.r.t #475 #497
What change is being introduced by this PR?
I have added an option of Hindi changed all the necessary files with appropriate documentation