Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#475 Update German translation #559

Merged
merged 1 commit into from
Oct 27, 2020
Merged

#475 Update German translation #559

merged 1 commit into from
Oct 27, 2020

Conversation

tuxinaut
Copy link
Contributor

Related issue

Closes #475

Context / Background

Update German translation

@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #559 into main will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
- Coverage   71.54%   71.42%   -0.12%     
==========================================
  Files          28       28              
  Lines        2583     2583              
  Branches      391      391              
==========================================
- Hits         1848     1845       -3     
- Misses        656      657       +1     
- Partials       79       81       +2     
Impacted Files Coverage Δ
js/update-manager.js 62.50% <0.00%> (-7.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f28f747...ce2a98e. Read the comment docs.

Copy link
Owner

@thamara thamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for the adjustments :)

@thamara thamara merged commit ff5c726 into thamara:main Oct 27, 2020
@thamara
Copy link
Owner

thamara commented Oct 27, 2020

Hey @tuxinaut, thank you again for these adjustments. Btw, On the German translation file, the following strings are missing translations:

{
  "$Notification": {
    "time-to-leave": "Hey there! I think it's time to leave.",
    "punch-reminder": "Don't forget to punch in!"
  },
  "$UpdateManager": {
    "dismissBtn": "Dismiss",
    "downloadBtn": "Download latest version",
    "remindBtn": "Remind me later",
    "title": "TTL Check for updates",
    "upto-date-msg": "Your TTL is up to date."
  }
}

Would you be interested in doing a PR to address those?

@tuxinaut
Copy link
Contributor Author

tuxinaut commented Oct 27, 2020

Sure, would it be possible to count the next PR against Hacktober 🤔 😄

@thamara
Copy link
Owner

thamara commented Oct 27, 2020

Oh! Don't mind at all! Because the repository is with the hacktoberfest tag, every merge PR is considered and should be available in your profiler :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translating Time to Leave to other Languages
2 participants