Close #847: Translate Time To Leave to Hebrew #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tupaschoal
reviewed
Oct 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #849 +/- ##
=======================================
Coverage 59.42% 59.42%
=======================================
Files 26 26
Lines 2080 2080
Branches 305 305
=======================================
Hits 1236 1236
Misses 844 844 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Removing all other readme links Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
tupaschoal
approved these changes
Oct 12, 2022
|
\changelog-update |
tupaschoal
changed the title
|
Thanks @TomerPacific! If in the future we have new or changed strings in the app, can we mention you for help on keeping Hebrew up-to-date? |
|
@tupaschoal - Of course. You can count on me. |
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #847
Context / Background
Following what was detailed in #475, I followed the guidelines and added a translation to Hebrew.
What change is being introduced by this PR?
src/configs/app.config.jsHow will this be tested?
I have looked at the markdown in a preview tool to see that it looks appropriately.