execution: add timing information #290
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's try using embedding to capture observability information for each operator instead of wrapping operator inside of operator. Main reasoning for this approach instead of the other way is to be able to catch more granular data like memory allocations. With wrapping we would have to have cross-references between operators and this seems cleaner to me. Need to explore this further to see how it looks like. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
GiedriusS
commented
Jul 3, 2023
| engine: e, | ||
| expr: expr, | ||
| t: RangeQuery, | ||
| debugWriter: e.debugWriter, | ||
| }, nil | ||
| } | ||
|
|
||
| type ExplainableQuery interface { |
There was a problem hiding this comment.
Maybe we can call it ObservableQuery now because it's not just Explain() anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try using embedding to capture observability information for each operator instead of wrapping operator inside of operator. Main reasoning for this approach instead of the other way is to be able to catch more granular data like memory allocations. With wrapping we would have to have cross-references between operators and this seems cleaner to me.
Need to explore this further to see how it looks like.