Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signatures for error! and a few other methods #6

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Add signatures for error! and a few other methods #6

merged 1 commit into from
Jul 3, 2024

Conversation

olivier-thatch
Copy link
Contributor

Add signatures for error! and a few other methods.

Primarily, type error! as returning T.noreturn so that Sorbet knows that error! never returns.

@olivier-thatch olivier-thatch merged commit 3122bc3 into main Jul 3, 2024
6 checks passed
@olivier-thatch olivier-thatch deleted the olivier-add-error-sig branch July 3, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@olivier-thatch