baseline http vs conductor overhead benchmark #1766
YassinEldeebci.yaml
on: pull_request
build & test
2m 58s
graphql-over-http
2m 37s
config-json-schema / integrity
44s
rustfmt + clippy
34s
panic-free-audit
14s
smoke test
2m 33s
Annotations
4 warnings
|
this expression creates a reference which is immediately dereferenced by the compiler:
libs/engine/src/schema_awareness.rs#L287
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> libs/engine/src/schema_awareness.rs:287:53
|
287 | let introspection = parse_introspection_str(&content).map_err(|source| {
| ^^^^^^^^ help: change this to: `content`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
libs/engine/src/schema_awareness.rs#L207
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> libs/engine/src/schema_awareness.rs:207:30
|
207 | parse_graphql_schema(&content).map(|schema| (content.clone(), schema))
| ^^^^^^^^ help: change this to: `content`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
libs/federation_query_planner/src/lib.rs#L88
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> libs/federation_query_planner/src/lib.rs:88:18
|
88 | query_steps: &Vec<QueryStep>,
| ^^^^^^^^^^^^^^^ help: change this to: `&[QueryStep]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
libs/tracing/src/otel_utils.rs#L46
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> libs/tracing/src/otel_utils.rs:46:11
|
46 | errors: &Vec<GraphQLError>,
| ^^^^^^^^^^^^^^^^^^ help: change this to: `&[GraphQLError]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|