Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InfoCard and Stud components for landing pages #1737

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Conversation

hasparus
Copy link
Collaborator

image image

Promoting these components from Hive website because we need them on the other landing pages.

Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: 44302aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@theguild/components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 17, 2024

📚 Storybook Deployment

The latest changes are available as preview in: https://d19372a6.the-guild-docs-storybook.pages.dev

Copy link
Contributor

github-actions bot commented Oct 17, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@theguild/components 7.1.0-alpha-20241021114709-44302aae0a589c88e18c29591fa8d455ab68632b npm ↗︎ unpkg ↗︎

Base automatically changed from update-graphqlconf-card to main October 18, 2024 18:49
return (
<Root className={cn('bg-beige-100 p-6 md:p-12', className)} {...rest}>
<Stud>{icon}</Stud>
<h3 className="mt-4 text-xl font-medium leading-[1.4] text-green-1000 md:mt-6">{heading}</h3>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h3 className="mt-4 text-xl font-medium leading-[1.4] text-green-1000 md:mt-6">{heading}</h3>
<h3 className="mt-4 text-xl font-medium leading-[1.4] text-green-1000 md:mt-6">{heading}</h3>

what's 1.4 stay for I guess it's 18px?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not 18px because it's text-xl. Just 1.4 of font-size. Copied it from Figma.

We can prolly remove it, as it's 20px * 1.4 == 28px, and Tailwind's text-xl includes line-height: 1.75rem which, with 16px html font-size is also 28px.

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh thx, and yes you right, you can remove it, also for the future there is shorthand text-xl/[value-of-your-leading]

Comment on lines +12 to +13
export const Default: StoryObj<InfoCardProps> = {
args: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const Default: StoryObj<InfoCardProps> = {
args: {
export const Default: StoryObj<InfoCardProps> = {
name: 'InfoCard',
args: {

like in Stud
image

to not have a list? or do you plan to add more stories here?

@hasparus hasparus merged commit 3bb5b4e into main Oct 21, 2024
5 checks passed
@hasparus hasparus deleted the stud-and-infocard branch October 21, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants