New plugin search color scheme #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 49f54ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hasparus
force-pushed
the
green-plugin-search
branch
from
56bec98 to
43eebd2
Compare
hasparus
commented
Oct 26, 2024
packages/components/src/components/marketplace-search.module.css
Outdated
Show resolved
Hide resolved
📚 Storybook DeploymentThe latest changes are available as preview in: https://d3d78ae4.the-guild-docs-storybook.pages.dev |
hasparus
force-pushed
the
green-plugin-search
branch
from
9e7d531 to
5a57a80
Compare
hasparus
force-pushed
the
green-plugin-search
branch
from
1f510ee to
035fbd4
Compare
hasparus
force-pushed
the
green-plugin-search
branch
from
dacd8cb to
d850653
Compare
dimaMachina
reviewed
Nov 6, 2024
packages/components/src/components/explore-main-product-cards.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
dimaMachina
reviewed
Nov 6, 2024
|
|
||
| if (!move) return; | ||
|
|
||
| if (move === '⬅️') { |
There was a problem hiding this comment.
why not just use:
Suggested change
| if (move === '⬅️') { | |
| if (event.key === 'ArrowLeft') { |
because it looks differently on each system in text editor
There was a problem hiding this comment.
I wanted to do the early return in line 195. Would have to reorder the control flow a bit to skip the "move" variable.
dimaMachina
reviewed
Nov 6, 2024
packages/components/src/components/marketplace-search.stories.ts
Outdated
Show resolved
Hide resolved
dimaMachina
reviewed
Nov 6, 2024
packages/components/src/components/tools-and-libraries-cards.tsx
Outdated
Show resolved
Hide resolved
dimaMachina
reviewed
Nov 6, 2024
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
dimaMachina
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video on Slack
Coming in 2 color schemes:
neutral, for docs and easy version bump on Envelop's/pluginspagegreen, for landing pagesneutralrespects user dark mode preference and renders in white or black,greenis always dark green.MarketplaceSearchnow renders just oneMarketplaceListat a time, andMarketplaceListrenders a grid up to 2 columns.