Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export sharedMetaItems for meta.ts files #1891

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Conversation

hasparus
Copy link
Collaborator

I'm adding this so we avoid error-prone copy paste among the websites, and keep a consistent mobile hamburger menu.

Already discussed this with @dimaMachina.

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: bac8485

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@theguild/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 16, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@theguild/components 8.1.2-alpha-20241218051656-bac8485cca2996034e05055280650603b9408e94 npm ↗︎ unpkg ↗︎

Copy link
Collaborator

@dimaMachina dimaMachina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be exported from @the-guild/components/server because _meta are server files

@dimaMachina dimaMachina merged commit 1510524 into main Dec 18, 2024
5 checks passed
@dimaMachina dimaMachina deleted the shared-meta-items branch December 18, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants