fix hidden decoration for Mesh product card on hover, when there is both <ExploreMainProductCards /> and <ToolsAndLibrariesCards /> on page
#1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 02779ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimaMachina
commented
Jan 6, 2025
📚 Storybook DeploymentThe latest changes are available as preview in: https://6a94cf24.the-guild-docs-storybook.pages.dev |
dimaMachina
commented
Jan 6, 2025
Comment on lines
-43
to
-44
| 'pointer-events-none absolute bottom-0 right-0 h-full fill-blue-200 opacity-0 transition-opacity duration-500 group-focus-within:opacity-100 group-hover:opacity-100', | ||
| isHive && 'fill-blue-700', |
There was a problem hiding this comment.
I don't think fill-blue-200 and fill-blue-700 were used before
dimaMachina
commented
Jan 6, 2025
| )} | ||
| preserveAspectRatio="xMidYMid meet" |
There was a problem hiding this comment.
why do we need this? I didn't see any change
hasparus
pushed a commit
that referenced
this pull request
Jan 8, 2025
…oth `<ExploreMainProductCards />` and `<ToolsAndLibrariesCards />` on page (#1951)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STORYBOOK
alternative approach of #1950 to fix svg id conflicts when both
<ExploreMainProductCards />and<ToolsAndLibrariesCards />components are on page due[&>:nth-child(n+4)]:[@media(min-width:1490px)]:hiddenclassStorybook
Screen.Recording.2025-01-07.at.03.16.39.mov
Example of both components in same page
Screen.Recording.2025-01-07.at.03.21.26.mov