Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextra 4 Blogpost #1803

Merged
merged 98 commits into from
Jan 13, 2025
Merged

Nextra 4 Blogpost #1803

merged 98 commits into from
Jan 13, 2025

Conversation

dimaMachina
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Jan 8, 2025

💻 Website Preview

The latest changes are available as preview in: https://2210febd.guild-dev-website.pages.dev

dimaMachina and others added 3 commits January 10, 2025 20:19
Co-authored-by: Saihajpreet Singh <saihajpreet.singh@gmail.com>
Co-authored-by: Saihajpreet Singh <saihajpreet.singh@gmail.com>
Co-authored-by: Saihajpreet Singh <saihajpreet.singh@gmail.com>
@87xie
Copy link
Contributor

87xie commented Jan 10, 2025

Some of my thoughts:

  • In v3, users might use useRouter from nextra/hooks, but it has been deprecated in v4. Do you think we should remind them about it here?
  • I’ve seen several questions about dynamic head tags, particularly regarding the title template. Since the head option in theme.config has been removed in v4, it might be helpful to include an example in the migration guide.
  • I prefer to reduce the heading levels to make the TOC content easier to read. I'm not sure if this change would be helpful, so I created a branch and made some adjustments to the "App Router Support" here.
  • I think a new "Trade-offs" heading could be added to the "App Router Support" to help users make better decisions. For example:
    • The catch-all route might require longer compilation times depending on the number of MDX files.
    • The page file convention works well with colocation, allowing you to keep all the assets for an article in one place.

website/pages/blog/nextra-4/index.mdx Outdated Show resolved Hide resolved
website/pages/blog/nextra-4/index.mdx Outdated Show resolved Hide resolved
@dimaMachina
Copy link
Collaborator Author

Some of my thoughts:

  • In v3, users might use useRouter from nextra/hooks, but it has been deprecated in v4. Do you think we should remind them about it here?

  • I’ve seen several questions about dynamic head tags, particularly regarding the title template. Since the head option in theme.config has been removed in v4, it might be helpful to include an example in the migration guide.

  • I prefer to reduce the heading levels to make the TOC content easier to read. I'm not sure if this change would be helpful, so I created a branch and made some adjustments to the "App Router Support" here.

  • I think a new "Trade-offs" heading could be added to the "App Router Support" to help users make better decisions. For example:

    • The catch-all route might require longer compilation times depending on the number of MDX files.
    • The page file convention works well with colocation, allowing you to keep all the assets for an article in one place.

Thanks @87xie I addressed all of your suggestions, and did a cherry pick of your commit

@dimaMachina dimaMachina requested a review from saihaj January 13, 2025 10:12
@dimaMachina dimaMachina changed the title wip blog Nextra 4 Blogpost Jan 13, 2025
@dimaMachina dimaMachina merged commit bde0ebc into master Jan 13, 2025
6 checks passed
@dimaMachina dimaMachina deleted the nextra-4 branch January 13, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants