Decode the input before building XML commands. #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted in issue #53, Coquille chokes on non-ASCII input because of encoding problems and Python throwing
UnicodeDecodeError
exceptions. This is a simple fix for the issue, it consists instr
, we turn it into aunicode
following the buffer's encoding)unicode
type in command encoding.My first tests work fine but it surely deserves to be checked.