Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json for Varanidae keyboard #1925

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Conversation

TokageItLab
Copy link
Contributor

Description

Add json for Varanidae keyboard recently merged in qmk_firmware.

QMK Pull Request

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove v2 definition (src/ folder version) as that is for legacy support of boards

v3/varanidae/varanidae.json Outdated Show resolved Hide resolved
@TokageItLab
Copy link
Contributor Author

TokageItLab commented Jul 1, 2023

Removed src/varanidae

@Xelus22 Xelus22 merged commit 6585f1b into the-via:master Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants