Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kradoindustries dev branch #1930

Merged
merged 4 commits into from
Jul 9, 2023
Merged

Kradoindustries dev branch #1930

merged 4 commits into from
Jul 9, 2023

Conversation

Feags
Copy link
Contributor

@Feags Feags commented Jul 4, 2023

Adding Krado Industries keyboards: Kousa TKL, Krado66, Promenade

Description

Added VIA jsons for Krado Industries keyboards: Kousa TKL, Krado66, and Promenade.

QMK Pull Request

qmk/qmk_firmware#20372

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Jul 8, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase/merge master into this branch to fix you branch

@Feags Feags force-pushed the kradoindustries-dev-branch branch from 99185bc to 4a5c654 Compare July 8, 2023 21:02
@Feags
Copy link
Contributor Author

Feags commented Jul 8, 2023

Please rebase/merge master into this branch to fix you branch

Rebased.

@Feags Feags requested a review from Xelus22 July 8, 2023 21:08
@Xelus22 Xelus22 merged commit 0ef9f78 into the-via:master Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Feags @Xelus22