Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QVEX Lynepad #1947

Merged
merged 3 commits into from
Jul 29, 2023
Merged

Add QVEX Lynepad #1947

merged 3 commits into from
Jul 29, 2023

Conversation

seflm
Copy link
Contributor

@seflm seflm commented Jul 11, 2023 •
edited
Loading

Description

Add QVEX Lynepad to VIA

QMK Pull Request

Lynepad support PR merged into QMK master on 11th July 2023.
qmk/qmk_firmware#21070

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@seflm seflm changed the title init Lynepad 2.0 Add QVEX Lynepad 2.0 Jul 11, 2023
@seflm seflm changed the title Add QVEX Lynepad 2.0 Add QVEX Lynepad Jul 11, 2023
@seflm
Copy link
Contributor Author

seflm commented Jul 13, 2023

Accidentally put a v3 definition in the src folder instead of the v3 folder, fixed.

Xelus22
Xelus22 requested changes Jul 15, 2023
View reviewed changes
v3/qvex/lynepad2/lynepad2.json Outdated Show resolved Hide resolved
@seflm seflm requested a review from Xelus22 July 17, 2023 13:59
@seflm
Copy link
Contributor Author

seflm commented Jul 18, 2023

Ended up creating a custom menu that is more suitable for what the Lynepad can do.

@Xelus22 Xelus22 merged commit eda05ba into the-via:master Jul 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seflm @Xelus22