Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v2 Fidelity json #1996

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Add v2 Fidelity json #1996

merged 1 commit into from
Aug 26, 2023

Conversation

mini-ninja-64
Copy link
Contributor

@mini-ninja-64 mini-ninja-64 commented Aug 21, 2023 •
edited
Loading

Description

Some users of this keyboard are still using v2 firmware, because of this would it be possible to add a v2 VIA definition for the keyboard on top of the existing v3 definition?

QMK Pull Request

qmk/qmk_firmware#20922

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Xelus22
Copy link
Collaborator

Xelus22 commented Aug 26, 2023

Ok just this once. Really shoudl be locking V2 because it is legacy by a year now.

@Xelus22 Xelus22 merged commit fb5c7f3 into the-via:master Aug 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mini-ninja-64 @Xelus22