Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add qk100 keyboard v2 and v3 files #1997

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Add qk100 keyboard v2 and v3 files #1997

merged 3 commits into from
Nov 5, 2023
+793 −0

Conversation

owlab-git
Copy link
Contributor

@owlab-git owlab-git commented Aug 22, 2023 •
edited
Loading

Description

QMK Pull Request

qmk/qmk_firmware#21782

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@owlab-git
Copy link
Contributor Author

Please check, thanks.

Xelus22
Xelus22 requested changes Oct 29, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove src/ folder ones. those are ONLY for legacy boards. we are no longer maintaining support for further legacy boards.

v3/qwertykeys/qk100/qk100_ansi.json Show resolved Hide resolved
v3/qwertykeys/qk100/qk100_solder.json Show resolved Hide resolved
v3/qwertykeys/qk100/qk100_solder.json Show resolved Hide resolved
@Xelus22 Xelus22 merged commit 94b8aac into the-via:master Nov 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owlab-git @Xelus22