Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plywrks ply8x #2002

Merged
merged 2 commits into from
Sep 3, 2023
Merged

Update plywrks ply8x #2002

merged 2 commits into from
Sep 3, 2023

Conversation

ramonimbao
Copy link
Contributor

@ramonimbao ramonimbao commented Aug 29, 2023 •
edited
Loading

Description

Removed keycodes. Switched from qmk_rgblight to qmk_rgb_matrix.

QMK Pull Request

qmk/qmk_firmware#21263

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Sep 2, 2023
View reviewed changes
v3/plywrks/ply8x.json
@@ -2,8 +2,7 @@
"name": "ply8x",
"vendorId": "0x706C",
"productId": "0x7905",
"keycodes": ["qmk_lighting"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should still keep this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I put it back

@ramonimbao
Update ply8x.json
2dea017 
Replace the keycodes item
@Xelus22 Xelus22 merged commit 357b726 into the-via:master Sep 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramonimbao @Xelus22