Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added rpk_001 keyboard #2021

Merged
merged 3 commits into from
Oct 22, 2023
Merged

Added rpk_001 keyboard #2021

merged 3 commits into from
Oct 22, 2023

Conversation

itarze
Copy link
Contributor

@itarze itarze commented Sep 21, 2023

Description

Added RPK-001 keyboard.

QMK Pull Request

qmk/qmk_firmware#21042

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Sep 23, 2023
View reviewed changes
v3/phentech/rpk_001/rpk_001.json Outdated
"vendorId": "0xAC12",
"productId": "0x2236",
"keycodes": ["qmk_lighting"],
"menus": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your keyboard in QMK firmware has no RGB animations enabled. Please enable them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qmk/qmk_firmware#22120 @Xelus22

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please simplify to just "menus": [ "qmk_rgb_matrix" ], since you have ALL effects enabled

v3/phentech/rpk_001/rpk_001.json Outdated Show resolved Hide resolved
@Xelus22 Xelus22 merged commit ae3c08e into the-via:master Oct 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itarze @Xelus22