Add support for plaque AD #2209
Open
+730
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding |
|
Alpha keys and modifier keys don't have colours assigned 🙈 |
dunk2k
suggested changes
Mar 28, 2024
| "keycodes": ["qmk_lighting"], | ||
| "menus": ["qmk_rgb_matrix"], | ||
| "layouts": { | ||
| "labels": [ |
There was a problem hiding this comment.
missing f12 function row (layout)
|
@dunk2k no point in submitting reviews at this time if the board isn't even merged in QMK main as per requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Plaque AD TKL PCB
QMK Pull Request
qmk/qmk_firmware#23359
Checklist
0xFEED