Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create haven60.json #2228

Merged
merged 6 commits into from
May 31, 2024
Merged

Create haven60.json #2228

merged 6 commits into from
May 31, 2024

Conversation

CMMS-Freather
Copy link
Contributor

add haven60 json

adding ah haven60 via support

Description

adding ah haven60 via support

QMK Pull Request

qmk/qmk_firmware#23062

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@CMMS-Freather
Create haven60.json
f7719a0 
add haven60 json
dunk2k
dunk2k suggested changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add 0.25 padding
  • add WKL and HHKB bottom row options
  • correct key colouring

v3/ah/haven60.json Outdated Show resolved Hide resolved
v3/ah/haven60.json Outdated Show resolved Hide resolved
CMMS-Freather and others added 2 commits April 5, 2024 15:17
@CMMS-Freather @dunk2k
Update v3/ah/haven60.json
3e89a5e 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@CMMS-Freather @dunk2k
Update v3/ah/haven60.json
0e20868 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
dunk2k
dunk2k suggested changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general formatting

v3/ah/haven60.json Outdated Show resolved Hide resolved
v3/ah/haven60.json Outdated Show resolved Hide resolved
v3/ah/haven60.json Outdated Show resolved Hide resolved
CMMS-Freather and others added 3 commits April 9, 2024 22:14
@CMMS-Freather @dunk2k
Update v3/ah/haven60.json
a170fc5 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@CMMS-Freather @dunk2k
Update v3/ah/haven60.json
b325f3a 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@CMMS-Freather @dunk2k
Update v3/ah/haven60.json
b946273 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@Xelus22 Xelus22 merged commit c47a165 into the-via:master May 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k approved these changes

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CMMS-Freather @Xelus22 @dunk2k