Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Archetype Minerva LX #2229

Merged
merged 8 commits into from
Apr 15, 2024
Merged

Conversation

archetype-made
Copy link
Contributor

Description

First support for Archetype Minerva

QMK Pull Request

qmk/qmk_firmware#23291

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

First support for Archetype Minerva LX
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting

v3/archetype/minervalx/Minerva_LX_via_040424.json Outdated Show resolved Hide resolved
v3/archetype/minervalx/Minerva_LX_via_040424.json Outdated Show resolved Hide resolved
v3/archetype/minervalx/Minerva_LX_via_040424.json Outdated Show resolved Hide resolved
Cipulot and others added 3 commits April 9, 2024 02:21
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@Cipulot
Copy link
Collaborator

Cipulot commented Apr 9, 2024

@archetype-made please change the file name so that it's v3/archetype/minervalx/minervalx.json instead of v3/archetype/minervalx/Minerva_LX_via_040424.json.

@Cipulot Cipulot added the needs work The PR needs fixes/ things need to be addressed label Apr 11, 2024
Updated file name for .json file
updated layout errors and right shift label
v3/archetype/minervalx/minervalx.json Outdated Show resolved Hide resolved
@Cipulot Cipulot removed the needs work The PR needs fixes/ things need to be addressed label Apr 15, 2024
@Cipulot Cipulot merged commit 3522481 into the-via:master Apr 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants