Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jaykeeb joker #2248

Merged
merged 2 commits into from
Apr 19, 2024
Merged

add jaykeeb joker #2248

merged 2 commits into from
Apr 19, 2024

Conversation

alabahuy
Copy link
Contributor

@alabahuy alabahuy commented Apr 19, 2024

Description

Add jaykeeb joker, 1800 layout for austin

QMK Pull Request

qmk/qmk_firmware#23535

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Cipulot
Copy link
Collaborator

Cipulot commented Apr 19, 2024

I've gone on and manually forced the correct key color scheme from the one presented here. Please tho.... check that the colors are actually correct and don't simply tick the "I have assigned alpha keys and modifier keys with the correct colors." just to play "tick the box".
Screenshot 2024-04-19 at 10 37 27 AM

v3/jaykeeb/joker/joker.json Outdated Show resolved Hide resolved
@Cipulot Cipulot merged commit 37ac252 into the-via:master Apr 19, 2024
2 checks passed
@alabahuy
Copy link
Contributor Author

im sorry for the color scheme, and thank you for merged :)

@alabahuy alabahuy deleted the Joker branch April 19, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants