Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Lisa #2259

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Add Lisa #2259

merged 2 commits into from
Apr 28, 2024

Conversation

key10iq
Copy link
Contributor

@key10iq key10iq commented Apr 23, 2024

Description

QMK Pull Request

qmk/qmk_firmware/pull/23575

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Cipulot
Cipulot requested changes Apr 28, 2024
View reviewed changes
v3/keyten/lisa/lisa.json Outdated Show resolved Hide resolved
@Cipulot
Copy link
Collaborator

Cipulot commented Apr 28, 2024

Cool layout btw 😄

@Cipulot Cipulot merged commit 1dfd86a into the-via:master Apr 28, 2024
2 checks passed
@key10iq key10iq deleted the lisa branch May 1, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cipulot Cipulot Cipulot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@key10iq @Cipulot