Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of KB38 #2261

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Removal of KB38 #2261

merged 1 commit into from
Apr 25, 2024

Conversation

Cipulot
Copy link
Collaborator

@Cipulot Cipulot commented Apr 25, 2024

Description

This reverts the addition of the KB38 by the PR #2224 .

The PR went through even tho the VID/PID didn't match the ones in QMK. Whether the mismatch was intentional or not PR merge rules dictate that the board is to be removed.

QMK Pull Request

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Cipulot Cipulot merged commit c0eb048 into the-via:master Apr 25, 2024
2 checks passed
@Cipulot Cipulot deleted the removal_kb38 branch April 25, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant