Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Jaykeeb jk65 #2285

Merged
merged 2 commits into from
Jun 2, 2024
Merged

add Jaykeeb jk65 #2285

merged 2 commits into from
Jun 2, 2024

Conversation

alabahuy
Copy link
Contributor

@alabahuy alabahuy commented May 6, 2024

Description

add jaykeeb jk65 support via, 65% support many case existing

QMK Pull Request

qmk/qmk_firmware#23536

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

https://www.caniusevia.com/docs/layouts#kle-json-rules

please update the colours with the KLE rules.

@alabahuy
Copy link
Contributor Author

alabahuy commented Jun 1, 2024

update colours done @Xelus22

@Xelus22 Xelus22 merged commit e2e824c into the-via:master Jun 2, 2024
2 checks passed
@alabahuy alabahuy deleted the jk65 branch June 11, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants