Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add crafwalk #2295

Merged
merged 2 commits into from
Jun 7, 2024
Merged

add crafwalk #2295

merged 2 commits into from
Jun 7, 2024

Conversation

sotoba
Copy link
Contributor

@sotoba sotoba commented Jun 1, 2024

Description

add craftwalk support

QMK Pull Request

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Jun 2, 2024
View reviewed changes
v3/craftwalk/craftwalk.json Show resolved Hide resolved
@sotoba @Xelus22
Update v3/craftwalk/craftwalk.json
ba54c70 
Co-authored-by: Xelus22 <17491233+Xelus22@users.noreply.github.com>
@sotoba sotoba requested a review from Xelus22 June 2, 2024 08:29
@Xelus22 Xelus22 merged commit 753dd65 into the-via:master Jun 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sotoba @Xelus22