Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add jaykeeb jk60 #2300

Merged
merged 3 commits into from
Jul 6, 2024
Merged

add jaykeeb jk60 #2300

merged 3 commits into from
Jul 6, 2024

Conversation

alabahuy
Copy link
Contributor

@alabahuy alabahuy commented Jun 11, 2024 •
edited
Loading

Description

add jaykeeb jk60, layout 60% support many case existing

QMK Pull Request

qmk/qmk_firmware#23876

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

dunk2k
dunk2k suggested changes Jun 16, 2024
View reviewed changes
v3/jaykeeb/jk60/jk60.json Outdated Show resolved Hide resolved
@alabahuy @dunk2k
Update formatting
bfbf0aa 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Xelus22
Xelus22 requested changes Jul 6, 2024
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

This will require decals

https://www.caniusevia.com/docs/layouts#layout-options

@alabahuy
Copy link
Contributor Author

alabahuy commented Jul 6, 2024

image

This will require decals

https://www.caniusevia.com/docs/layouts#layout-options

oke done

@Xelus22 Xelus22 merged commit 25e9996 into the-via:master Jul 6, 2024
2 checks passed
@alabahuy alabahuy deleted the jk60 branch July 7, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k requested changes

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alabahuy @Xelus22 @dunk2k