Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add boardsource/the_q #2308

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Add boardsource/the_q #2308

merged 5 commits into from
Oct 14, 2024

Conversation

waffle87
Copy link
Contributor

@waffle87 waffle87 commented Jun 21, 2024 •
edited
Loading

Description

Adds v3 definition of Boardsouce The Q keyboard

QMK Pull Request

qmk/qmk_firmware:23782

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@waffle87 waffle87 marked this pull request as ready for review July 11, 2024 18:35
@Cipulot Cipulot added the needs work The PR needs fixes/ things need to be addressed label Oct 8, 2024
@waffle87 waffle87 requested a review from Cipulot October 13, 2024 06:29
@Cipulot
Copy link
Collaborator

Cipulot commented Oct 14, 2024

Keymap mode after QMK breaking change here: https://github.com/the-via/qmk_userspace_via/tree/main/keyboards/boardsource/the_q

Cipulot
Cipulot approved these changes Oct 14, 2024
View reviewed changes
v3/boardsource/the_q/the_q.json Outdated Show resolved Hide resolved
@Cipulot Cipulot merged commit 4aa29df into the-via:master Oct 14, 2024
2 checks passed
@waffle87 waffle87 deleted the kb/bs_the_q branch October 14, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cipulot Cipulot Cipulot approved these changes

@Xelus22 Xelus22 Xelus22 left review comments

Assignees
No one assigned
Labels
needs work The PR needs fixes/ things need to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waffle87 @Cipulot @Xelus22