Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cycle7 #2309

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Cycle7 #2309

wants to merge 2 commits into from

Conversation

Vertex-kb
Copy link
Contributor

Description

Add Cycle7

QMK Pull Request

qmk/qmk_firmware#23290

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove V2 version (src/ folder one) as this is legacy and we do not accept anymore pull requests for them.

@Vertex-kb
Copy link
Contributor Author

Hello, the firmware at that time was version V2, and these PCBs have already been in the hands of users. Can you be accommodating?

@Xelus22
Copy link
Collaborator

Xelus22 commented Jul 27, 2024

Hello, the firmware at that time was version V2, and these PCBs have already been in the hands of users. Can you be accommodating?

Your QMK PR was only 2 months ago, V2 has been deprecated for at least 1 year already.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per comments, please delete this file

Comment on lines +12 to +18
"layouts": {
"labels":[
"Split Backspace",
"ISO Enter",
"Split Left Shift",
"Split Right Shift",
["Bottom Row", "Ansi", "Tsangan","Wkl"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please format this section of code

@Cipulot
Copy link
Collaborator

Cipulot commented Oct 8, 2024

VIA Keymap moved after last QMK Breaking Changes: https://github.com/the-via/qmk_userspace_via/tree/main/keyboards/vertex/cycle7/keymaps/via

The PR opener should delete the V2 defs since they are not needed nor used and apply the formatting of the json in V3.

@Cipulot Cipulot added changes required needs work The PR needs fixes/ things need to be addressed and removed changes required labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work The PR needs fixes/ things need to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants