-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cycle7 #2309
base: master
Are you sure you want to change the base?
Add Cycle7 #2309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove V2 version (src/ folder one) as this is legacy and we do not accept anymore pull requests for them.
Hello, the firmware at that time was version V2, and these PCBs have already been in the hands of users. Can you be accommodating? |
Your QMK PR was only 2 months ago, V2 has been deprecated for at least 1 year already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per comments, please delete this file
"layouts": { | ||
"labels":[ | ||
"Split Backspace", | ||
"ISO Enter", | ||
"Split Left Shift", | ||
"Split Right Shift", | ||
["Bottom Row", "Ansi", "Tsangan","Wkl"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please format this section of code
VIA Keymap moved after last QMK Breaking Changes: https://github.com/the-via/qmk_userspace_via/tree/main/keyboards/vertex/cycle7/keymaps/via The PR opener should delete the V2 defs since they are not needed nor used and apply the formatting of the json in V3. |
Description
Add Cycle7
QMK Pull Request
qmk/qmk_firmware#23290
Checklist
0xFEED