Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for recore_v3 keyboard #2328

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

joliverMI
Copy link
Contributor

@joliverMI joliverMI commented Aug 9, 2024

Adding support for version 3 of recore keyboard. It is an ergonomic, split keyboard.

This keyboard has a hardware repeat function that can be customized by users in VIA.
The LED colors indicate which type of layer is active and if caps is activated. Those colors can be selected by users using VIA as well.

This is similar to #2201 with a different layout.

Description

QMK Pull Request

qmk/qmk_firmware/pull/23320

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@joliverMI
Copy link
Contributor Author

@Cipulot I just wanted to check to make sure I did everything appropriately. Perhaps this PR is not appearing for review. No rush, just checking!

@Cipulot
Copy link
Collaborator

Cipulot commented Oct 8, 2024

VIA Keymap moved after the QMK Breaking changes: https://github.com/the-via/qmk_userspace_via/tree/main/keyboards/pmk/recore/v3/keymaps/via

@joliverMI

If the #2201 and this PR make use of the Custom UI elements then you should open PRs to https://github.com/the-via/qmk_userspace_via to include the code that handles the controls.

The PR for both in the aforementioned repo is required in case they use the custom menu handling, as it seems to be the same since the custom enum IDs are 0, XX.

@Cipulot Cipulot added needs work The PR needs fixes/ things need to be addressed pending VIA keymap merge Waiting for merge into VIA keymap labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work The PR needs fixes/ things need to be addressed pending VIA keymap merge Waiting for merge into VIA keymap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants