Skip to content

Commit

Permalink
Add TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
liadomide committed Mar 20, 2024
1 parent 4750d13 commit 62a1351
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ mne>=1.0
numpy<1.24
plotly==5.14.0
pythreejs
pyvista==0.41.0
pyvista==0.41.0 # from version 0.42 backend pythreejs is removed - we use it in the HeadWidget
ipyreact==0.4.1
tvb-library>=2.5
tvb-framework
Expand Down
6 changes: 4 additions & 2 deletions tvbwidgets/ui/connectivity_ipy/connectivity_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import ipywidgets
import matplotlib
import numpy
import pyvista as pv
import pyvista
import numpy as np
from numpy import ndarray
from tvb.basic.neotraits.api import HasTraits
Expand All @@ -21,6 +21,8 @@

DROPDOWN_KEY = 'dropdown'

# TODO see latest releases of pyvista have this backend removed
pyvista.set_jupyter_backend('pythreejs')

class CustomOutput(ipywidgets.Output):
CONFIG = ConnectivityConfig()
Expand Down Expand Up @@ -168,7 +170,7 @@ def __add_actors(self):
plotter = self.output.plotter
points = CONTEXT.connectivity.centres

mesh_points = pv.PolyData(points)
mesh_points = pyvista.PolyData(points)

points_color = self.output.CONFIG.points_color
points_size = self.output.CONFIG.point_size
Expand Down
1 change: 1 addition & 0 deletions tvbwidgets/ui/head_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
from tvbwidgets.ui.base_widget import TVBWidget
from tvbwidgets.ui.widget_with_browser import TVBWidgetWithBrowser

# TODO see latest releases of pyvista have this backend removed
pyvista.set_jupyter_backend('pythreejs')


Expand Down

0 comments on commit 62a1351

Please sign in to comment.