Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PhasePlaneWidget #62

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Fix for PhasePlaneWidget #62

merged 2 commits into from
Nov 1, 2023

Conversation

liadomide
Copy link
Member

Fix for then PhasePlaneWidget is receiving a stochastic integrator directly in the constructor
This closes #61

@liadomide
Copy link
Member Author

liadomide commented Sep 22, 2023

The notebooks run is failing from a different cause. It will be fixed in another PR.
From my perspective this fix is ready for review (and if ok, merge)

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

Copy link

@i-Zaak i-Zaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Sorry for the delay, this one fell through the cracks.

@liadomide liadomide merged commit 7aee7f4 into main Nov 1, 2023
10 of 12 checks passed
@liadomide liadomide deleted the GIT-1 branch November 1, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Widget not initialized correctly with stochastic integrator
2 participants