Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WID-247 ConnectivityMatrixEditor widget #76

Merged
merged 21 commits into from
Sep 10, 2024

Conversation

peeplika
Copy link
Contributor

No description provided.

@romina1601 romina1601 self-requested a review July 22, 2024 08:11
@915-Misan-Teodora
Copy link
Contributor

I tested the widget and I have some suggestions:

  • the canvas is really big on my screen - I saw that width/height are hardcoded, maybe you can let the user choose its dimensions
  • when you click on a cell the page is scrolling up and it selects another cell than the desired one(probably bcs of its size- I tested with a smaller size and it does not scroll the page anymore) - maybe there is a way to disable the scroll or just make the canvas smaller
  • the values from the colored legend matrix could be displayed from the upper bound value to the lower bound (as in tvb-web)
  • when changing a cell value to a bigger one not from the range(to say 30 or 300) the others cells color should change as well because of the scale - you can test it in tvb-web to see the differences
  • the labels of the region are not so visible

@liadomide liadomide added enhancement New feature or request good first issue Good for newcomers labels Jul 23, 2024
@romina1601
Copy link
Member

Hi @peeplika ,
I tested the widget and there is something not working as expected.

I tried using other connectivities, not the default one. For this I added an argument in the from_file() method like this: conn = Connectivity().from_file("connectivity_66.zip") or conn = Connectivity().from_file("connectivity_96.zip"). In these cases, the labels are not aligned with the connectivity cells and/or the connectivity cells are overlapping:

  • connectivity_66.zip:
    image
  • connectivity_96.zip:
    image

As you can imagine, modifying the cell values doesn't work either, so could you take a look at this?

@romina1601
Copy link
Member

hey @peeplika ,
thanks for the changes! works and looks good, but I have a small observation. I saw that you made the window scrollable, but could you make the height of this window a bit bigger?
image

Also, I saw that after clicking on the save button, the ID displayed in the dropdown list does get updated. Could you change it such that the ID of the newly saved connectivity is displayed?

@liadomide liadomide changed the title WIP WID247 ConnectivityMatrixEditor widget WID247 ConnectivityMatrixEditor widget Sep 10, 2024
@liadomide liadomide changed the title WID247 ConnectivityMatrixEditor widget WID-247 ConnectivityMatrixEditor widget Sep 10, 2024
@915-Misan-Teodora 915-Misan-Teodora merged commit a6ba79e into the-virtual-brain:main Sep 10, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants