Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to add the inline source support by changing the
FetchFileSystem
.I added a
FetchFileSource
class to help determine data sources, from URL or inline sources.When the source is an inline source, the
load_src
method ofKiCanvasEmbedElement
will use two attributes. The filename will be obtained from the attributeoriginname
and thetype
attribute describes the file type. When theoriginname
attribute is empty, that will generate a default name for this file. Likewise, it will determine whether the inline source is sch or pcb by the first few characters when thetype
attribute is empty.Finally, the file type and the origin name will be contacted, and it as the inline source file name.