Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the inline source support. #56

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

XiangYyang
Copy link
Contributor

I tried to add the inline source support by changing the FetchFileSystem.

I added a FetchFileSource class to help determine data sources, from URL or inline sources.

When the source is an inline source, the load_src method of KiCanvasEmbedElement will use two attributes. The filename will be obtained from the attribute originname and the type attribute describes the file type. When the originname attribute is empty, that will generate a default name for this file. Likewise, it will determine whether the inline source is sch or pcb by the first few characters when the type attribute is empty.

Finally, the file type and the origin name will be contacted, and it as the inline source file name.

@theacodes
Copy link
Owner

Thanks for doing this! I'll take a look when I have a chance - probably this weekend or early next week. :)

@XiangYyang
Copy link
Contributor Author

Could you please review this pr? Thanks.

@theacodes
Copy link
Owner

theacodes commented Jan 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants