Add the inline source support. #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be is the length limit?)
|
Thanks for doing this! I'll take a look when I have a chance - probably this weekend or early next week. :) |
|
Could you please review this pr? Thanks. |
|
I will once I have enough time to review it thoroughly.
…On Thu, Jan 11, 2024 at 9:09 PM 向阳 ***@***.***> wrote:
Could you please review this pr? Thanks.
—
Reply to this email directly, view it on GitHub
<#56 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB5I42E7UANHFA2J74EOO3YOCLOXAVCNFSM6AAAAAA7F27GISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBYGMYDGMZSGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to add the inline source support by changing the
FetchFileSystem.I added a
FetchFileSourceclass to help determine data sources, from URL or inline sources.When the source is an inline source, the
load_srcmethod ofKiCanvasEmbedElementwill use two attributes. The filename will be obtained from the attributeoriginnameand thetypeattribute describes the file type. When theoriginnameattribute is empty, that will generate a default name for this file. Likewise, it will determine whether the inline source is sch or pcb by the first few characters when thetypeattribute is empty.Finally, the file type and the origin name will be contacted, and it as the inline source file name.