add contrast to vim colors

[ucodery]

What is this PR about?

[ ] closes issue number #

I've been using this colorscheme for about a year in Neovim and it's great except that I can never visually find my search matches. I think this adjusted colorscheme does a much better job.

Which editor(s) does this change concern?

• VS Code
• Sublime
• JetBrains
• Atom
• Pygments
• Other: Vim

The changes are for the following theme variant(s):

• Hypercolor
• Classic

(If your change is only for one of these, please consider submitting an issue to document it to other contributors that these features are missing from the other variant. Having them listed in an issue makes it easier for people to contribute! 🎉)

Screenshots

All screenshots are of the vim buffer created by :so $VIMRUNTIME/syntax/hitest.vim, with an active search of Highlight

These are the two current colorschemes

And these are the two new colorschemes

[jsit]

I think you may find that my recent PR #37 will have solved this contrast issue. I didn't use exactly the colors you did (sorry, I didn't see this PR), but it's similar and things should be more readable now.

[ucodery]

@jsit no problem, your PR also makes the situation much better. However, one correction I made could still stand to be included, which is that Visual in Hypercolor is still very close to a black-on-black. I will discard my other changes and just make both colorschemes use the same fg:bg for Visual (your Classic Visual is much better than when I opened this issue originally)

[theacodes]

Sounds great, y'all let me know when this is good to be merged. :)

[ucodery]

Hmm, this may be a bug on my end as I see in the master branch that Visual is set to the same for both colorschemes, and I can confirm that version of the file is what I have locally. But I see very different highlighting when I set a colorscheme in the console.

In nvim while colorscheme witchhazel: Visual xxx ctermbg=8 guibg=#716799
but while colorscheme witchhazel-hypercolor: Visual xxx ctermbg=8 guibg=#131218

I will report back.

[ucodery]

After actually carefully reading these files I realized that while both colorschemes set call <SID>X("Visual", "", s:amethyst, "") they define what amethyst is very differently (see last two screenshots). So my final collapsed contribution here is to pick a different premixed color for witchhazel-hypercolor visual backgropund. This results in the following contrast:

The wtichhazel colorscheme is at this point unchanged (so still what is is in the last comment's second screencap).