Devops/fairspc 57 GitHub actions

[tgreenwood]

No description provided.

[ewelinagr]

it looks like we've been using the main project ./VERSION file for image tags, I see that the project specific ones haven't been updated for 5 years...
I think it makes sense to have single version file for this repo (and to remove project specific ones), otherwise it will be easy to create inconsistencies and confusion which hub image works with which singleuser one, keep it also consistent with helm chart version.

[tgreenwood]

agree, done

[ewelinagr]

same here, see the comment about repo version file

[tgreenwood]

done

[ewelinagr]

Similar case as for Keycloak repo - it would be nice to have some build on PR, at least checking if image build is not failing, when creating a PR. That was the case with Travis.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[tgreenwood]

Similar case as for Keycloak repo - it would be nice to have some build on PR, at least checking if image build is not failing, when creating a PR. That was the case with Travis.

@ewelinagr agree with you, reasonable, made the push step conditional

[ewelinagr]

Similar case as for Keycloak repo - it would be nice to have some build on PR, at least checking if image build is not failing, when creating a PR. That was the case with Travis.

@ewelinagr agree with you, reasonable, made the push step conditional

Sounds good! It looks like the condition on helm chart pushing works, but from the docker action log it looks like the images were pushed anyway. Maybe it is just the way the jobs are grouped now. For helm pushing is separate action, for docker build and push is together so it is shown as done

[tgreenwood]

Similar case as for Keycloak repo - it would be nice to have some build on PR, at least checking if image build is not failing, when creating a PR. That was the case with Travis.

@ewelinagr agree with you, reasonable, made the push step conditional

Sounds good! It looks like the condition on helm chart pushing works, but from the docker action log it looks like the images were pushed anyway. Maybe it is just the way the jobs are grouped now. For helm pushing is separate action, for docker build and push is together so it is shown as done

@ewelinagr it might look confusing, I understand, but yes, it is done because it is combined step including both building and pushing. There is a conditional property push: ${{github.ref == 'refs/heads/release' || github.ref == 'refs/heads/dev'}}, added on Friday. Once it is true, the built image is pushed as well. Checked just in case, it works correctly