Skip to content

Commit

Permalink
Update fairspace-ingress.yaml to allow pathType override
Browse files Browse the repository at this point in the history
ImplementationSpecific will break the intended functionality or ingress providers which do not default to prefix matching, such as the AWS ALB.
  • Loading branch information
jayz28 authored and Jay Lee committed Nov 5, 2024
1 parent 07b6e3a commit b0ad918
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/fairspace/templates/ingress/fairspace-ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ spec:
http:
paths:
- path: /
pathType: ImplementationSpecific
pathType: {{ $ingress.pathType | default "ImplementationSpecific" }}
backend:
service:
name: {{ .Release.Name }}
Expand Down
5 changes: 4 additions & 1 deletion charts/fairspace/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,15 @@ external:
clientSecret:

# Setup ingress for fairspace components
# Change pathType to "Prefix" for ingress providers which do not default to prefix or wildcard
# matching for the "/" path, eg: AWS ALB
fairspace:
name: "fairspace"
description: "Fairspace"
ingress:
enabled: true
domain:
pathType: ImplementationSpecific
annotations:
pluto:
kubernetes.io/ingress.class: nginx
Expand Down Expand Up @@ -185,4 +188,4 @@ postgres:
# Pod annotations should remain empty. They are filled within the build process
podAnnotations: { }

svgicons: { }
svgicons: { }

0 comments on commit b0ad918

Please sign in to comment.