add unit tests and fix related issues

composer.json

@@ -13,9 +13,7 @@
     ],
     "autoload": {
         "psr-4": {
-            "TheIconic\\Synopsis\\": [
-                "src/"
-            ]
+            "TheIconic\\Synopsis\\": ["src/", "tests/"]
         }
     },
     "require": {}

phpunit.xml.dist

@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit colors="true"
+    convertErrorsToExceptions="true"
+    convertNoticesToExceptions="true"
+    convertWarningsToExceptions="true"
+    stopOnFailure="false"
+    verbose="true"
+    bootstrap="vendor/autoload.php">
+
+    <php>
+        <ini name="memory_limit" value="-1"/>
+    </php>
+
+    <filter>
+        <whitelist addUncoveredFilesFromWhitelist="true">
+            <directory suffix=".php">src</directory>
+            <exclude>
+                <!--Don't want to measure code coverage from test classes.-->
+                <directory suffix=".php">tests</directory>
+            </exclude>
+        </whitelist>
+    </filter>
+
+    <testsuites>
+        <testsuite name="Synopsis">
+            <directory suffix=".php">tests</directory>
+        </testsuite>
+    </testsuites>
+</phpunit>

src/AbstractSynopsis.php

@@ -12,7 +12,6 @@
  */
 abstract class AbstractSynopsis
 {
-
     /**
      * @var string the type
      */
@@ -46,15 +45,14 @@ abstract class AbstractSynopsis
      */
     public function process($value, $depth)
     {
-        $this->type = strtolower(str_replace('Synopsis', '', str_replace(__NAMESPACE__ . '\\', '', get_class($this))));
+        $parts = explode('\\', get_class($this));
+        $this->type = strtolower(str_replace('Synopsis', '', end($parts)));
 
         if (is_scalar($value)) {
             $this->value = (string) $value;
             $this->length = strlen((string) $value);
-        } else {
-            if ($this->value instanceof Countable) {
-                $this->length = count($value);
-            }
+        } else if ($value instanceof Countable) {
+            $this->length = count($value);
         }
     }
 

src/ArraySynopsis.php

@@ -9,7 +9,6 @@
  */
 class ArraySynopsis extends AbstractSynopsis
 {
-
     /**
      * @see parent::process()
      * @param $value

src/BooleanSynopsis.php

@@ -9,7 +9,6 @@
  */
 class BooleanSynopsis extends AbstractSynopsis
 {
-
     /**
      * @see parent::process()
      * @param $value

src/DoubleSynopsis.php

@@ -9,7 +9,6 @@
  */
 class DoubleSynopsis extends AbstractSynopsis
 {
-
     /**
      * @see parent::process()
      * @param $value

src/Exception/TraceSynopsis.php

@@ -11,7 +11,6 @@
  */
 class TraceSynopsis extends AbstractSynopsis
 {
-
     /**
      * @var string the file
      */
@@ -43,9 +42,13 @@ public function process($value, $depth)
 
         $this->value = sprintf('%s()', (!empty($value['class'])) ? ($value['class'] . $value['type'] . $value['function']) : $value['function']);
 
-        $this->length = $this->line = $value['line'];
+        if (isset($value['line'])) {
+            $this->length = $this->line = $value['line'];
+        }
 
-        $this->type = $this->file = $value['file'];
+        if (isset($value['file'])) {
+            $this->type = $this->file = $value['file'];
+        }
 
         $this->function = $value['function'];
 

src/ExceptionSynopsis.php

@@ -3,6 +3,7 @@
 namespace TheIconic\Synopsis;
 
 use TheIconic\Synopsis\Exception\TraceSynopsis;
+use Exception;
 
 /**
  * represents and exception
@@ -11,7 +12,6 @@
  */
 class ExceptionSynopsis extends ObjectSynopsis
 {
-
     /**
      * @var string the file
      */
@@ -41,7 +41,10 @@ public function process($value, $depth)
 
         // we omit the $depth check here on purpose
         foreach ($value->getTrace() as $k => $trace) {
-            $this->addChild(new TraceSynopsis($trace, $depth), '#' . $k);
+            $child = new TraceSynopsis();
+            $child->setFactory($this->getFactory());
+            $child->process($trace, $depth);
+            $this->addChild($child, '#' . $k);
         }
     }
 }

src/Factory.php

@@ -11,28 +11,27 @@
  */
 class Factory
 {
-
     /**
      * @var array mappings from value classes to synopsis classes
      */
-    protected $objectMap = array(
+    protected $objectMap = [
         'Transfer_AbstractObject' => 'TransferObject',
         'Transfer_AbstractCollection' => 'TransferCollection',
         'Iterator' => 'Iterator',
         'IteratorAggregate' => 'Iterator',
         'ArrayAccess' => 'Iterator',
-    );
+    ];
 
     /**
      * @var array mappings from resource types to synopsis classes
      */
-    protected $resourceMap = array(
+    protected $resourceMap = [
         'bzip2' => 'File',
         'cpdf' => 'File',
         'fdf' => 'File',
         'zlib' => 'File',
         'stream' => 'Stream',
-    );
+    ];
 
     /**
      * creates the fitting synopsis instance for a value

src/Formatter/AbstractFormatter.php

@@ -10,7 +10,6 @@
  */
 abstract class AbstractFormatter
 {
-
     /**
      * @param AbstractSynopsis $synopsis
      * @param string|null $key

src/Formatter/LogFileFormatter.php

@@ -11,7 +11,6 @@
  */
 class LogFileFormatter
 {
-
     /**
      * @var int the current level in the tree
      */
@@ -56,7 +55,7 @@ protected function formatTreeSynopsis(AbstractSynopsis $synopsis, $key)
 
         $this->level++;
         foreach ($synopsis->getChildren() as $k => $v) {
-            $formatted[] = str_repeat(' ', $this->level) . $this->format($v, $k);
+            $formatted[] = str_repeat(' ', $this->level * 2) . $this->format($v, $k);
         }
         $this->level--;
 

src/Object/IteratorSynopsis.php

@@ -11,7 +11,6 @@
  */
 class IteratorSynopsis extends ObjectSynopsis
 {
-
     /**
      * @see parent::process()
      * @param $value

src/Object/TransferObjectSynopsis.php

@@ -11,7 +11,6 @@
  */
 class TransferObjectSynopsis extends ObjectSynopsis
 {
-
     /**
      * @see parent::process()
      * @param $value

src/ObjectSynopsis.php

@@ -12,7 +12,6 @@
  */
 class ObjectSynopsis extends AbstractSynopsis
 {
-
     /**
      * @var string the namespace
      */

src/Resource/FileSynopsis.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace TheIconic\Synopsis\Object;
+namespace TheIconic\Synopsis\Resource;
 
 use TheIconic\Synopsis\ResourceSynopsis;
 
@@ -11,4 +11,17 @@
  */
 class FileSynopsis extends ResourceSynopsis
 {
+    /**
+     * @param $value
+     * @param $depth
+     */
+    public function process($value, $depth)
+    {
+        parent::process($value, $depth);
+
+        $meta = stream_get_meta_data($value);
+
+        $this->value = $meta['uri'];
+        $this->length = strlen($this->value);
+    }
 }

src/Resource/StreamSynopsis.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace TheIconic\Synopsis\Object;
+namespace TheIconic\Synopsis\Resource;
 
 use TheIconic\Synopsis\ResourceSynopsis;
 
@@ -11,4 +11,17 @@
  */
 class StreamSynopsis extends ResourceSynopsis
 {
+    /**
+     * @param $value
+     * @param $depth
+     */
+    public function process($value, $depth)
+    {
+        parent::process($value, $depth);
+
+        $meta = stream_get_meta_data($value);
+
+        $this->value = $meta['uri'];
+        $this->length = strlen($this->value);
+    }
 }

src/StandardSynopsis.php

@@ -9,4 +9,31 @@
  */
 class StandardSynopsis extends AbstractSynopsis
 {
+    /**
+     * @param $value
+     * @param $depth
+     */
+    public function process($value, $depth)
+    {
+        parent::process($value, $depth);
+
+        $this->type = $this->detectType($value);
+    }
+
+    /**
+     * @param $value
+     * @return string
+     */
+    protected function detectType($value)
+    {
+        if ($value === null) {
+            $type = 'null';
+        } elseif ($value instanceof Exception) {
+            $type = 'exception';
+        } else {
+            $type = gettype($value);
+        }
+
+        return $type;
+    }
 }

tests/ArraySynopsisTest.php

@@ -0,0 +1,54 @@
+<?php
+
+namespace TheIconic\Synopsis;
+
+use PHPUnit\Framework\TestCase;
+use Exception;
+use TheIconic\Synopsis\AbstractSynopsis;
+use TheIconic\Synopsis\ArraySynopsis;
+use TheIconic\Synopsis\Factory;
+use TheIconic\Synopsis\StringSynopsis;
+
+class ArraySynopsisTest extends TestCase
+{
+    /**
+     *
+     */
+    public function testProcess()
+    {
+        $synopsis = new ArraySynopsis();
+        $synopsis->setFactory($this->getMockFactory());
+        $synopsis->process([
+            'a' => 'b',
+            'c' => 'd',
+        ], 3);
+
+        $this->assertEquals('array', $synopsis->getType());
+        $this->assertEquals(2, $synopsis->getLength());
+        $this->assertEquals('', $synopsis->getValue());
+        $this->assertTrue($synopsis->hasChildren());
+
+        $children = $synopsis->getChildren();
+        $this->assertCount(2, $children);
+
+        $this->assertEquals(1, $children['a']);
+        $this->assertEquals(2, $children['c']);
+    }
+
+    /**
+     * @return Factory
+     */
+    protected function getMockFactory()
+    {
+        $factory = $this->getMockBuilder(Factory::class)
+            ->setMethods(['synopsize'])
+            ->getMock();
+
+        $factory->expects($this->exactly(2))
+            ->method('synopsize')
+            ->withConsecutive(['b'], ['d'])
+            ->willReturnOnConsecutiveCalls(1, 2);
+
+        return $factory;
+    }
+}

tests/BooleanSynopsisTest.php

@@ -0,0 +1,28 @@
+<?php
+
+namespace TheIconic\Synopsis;
+
+use PHPUnit\Framework\TestCase;
+use Exception;
+use TheIconic\Synopsis\AbstractSynopsis;
+use TheIconic\Synopsis\ArraySynopsis;
+use TheIconic\Synopsis\Factory;
+use TheIconic\Synopsis\StringSynopsis;
+
+class BooleanSynopsisTest extends TestCase
+{
+    /**
+     *
+     */
+    public function testProcess()
+    {
+        $synopsis = new BooleanSynopsis();
+        $synopsis->process(true, 3);
+
+        $this->assertEquals('boolean', $synopsis->getType());
+        $this->assertEquals(1, $synopsis->getLength());
+        $this->assertEquals('true', $synopsis->getValue());
+        $this->assertFalse($synopsis->hasChildren());
+        $this->assertNull($synopsis->getChildren());
+    }
+}