Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ketch can't deploy new apps after failure
When an invalid field is set in the App CR like so (it can be any invalid field): ``` volumes: - name: aaa/bbb persistentVolumeClaim: claimName: aaa/bbb ``` The following kubernetes event will get emitted: ``` failed to get deploy events: create Pod bulletinboard-web-1-0 in StatefulSet bulletinboard-web-1 failed error: Pod "bulletinboard-web-1-0" is invalid: spec.volumes[0].name: Invalid value: "aaa/bbb": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?') ``` Due to this, the following for loop will never break as the ObservedGeneration will never increase from 0 due to the invalid field, only until 10 minutes has elapsed with the ctx: ketch/app_controller.go at c6aa420 · theketchio/ketch Additional logic within wl, err = cli.Get(ctx) to check the event associated with the workload and return the error on a specific condition (e.Type == "Warning" && e.Reason == "FailedCreate") was added
- Loading branch information